[bug #53941] NSProcessInfo -systemUptime test sometimes fails on GNU/Hurd

[Yavor Doganov]

URL:
<http://savannah.gnu.org/bugs/?53941>

Summary: NSProcessInfo -systemUptime test sometimes fails on
GNU/Hurd
Project: GNUstep
Submitted by: yavor
Submitted on: Sat 19 May 2018 12:55:21 PM EEST
Category: Base/Foundation
Severity: 3 - Normal
Item Group: Bug
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any

_______________________________________________________

Details:

On GNU/Hurd, procfs is optional -- the system works just as well without it.
Debian's hurd-i386 buildds are configured with procfs but for some reason from
time to time the test (as well as the configure test for procfs) fails. See
https://lists.debian.org/debian-hurd/2018/02/msg00017.html for details.

As this method is a no-op if neither procfs nor sysctlbyname are available I'd
suggest to not compile/run the test if these conditions are not met. Patch
attached.



_______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 19 May 2018 12:55:21 PM EEST Name:
conditional-systemUptime-test.patch Size: 1KiB By: yavor

<http://savannah.gnu.org/bugs/download.php?file_id=44178>

_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?53941>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

[Fred Kiefer]

Update of bug #53941 (project gnustep):

Status: None => Ready For Test
Assigned to: None => FredKiefer
Open/Closed: Open => In Test

_______________________________________________________

Follow-up Comment #1:

I fixed this test somewhat differently by marking it as hopeful. First off I
didn't like the idea of making tests conditional on specific defines and there
was also the case of WIN32 missing.

With the current solution the test will sometimes fail on GNU Hurd but in that
case it will only be reported as a dashed hope and your build should proceed.

_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?53941>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

[Yavor Doganov]

Follow-up Comment #2, bug #53941 (project gnustep):

Thanks, works for me. Sorry for missing Windows, I just wasn't careful
enough.

I see nothing wrong in making tests conditional based on defines; running the
testsuite assumes a configured tree. Besides, that is already done for some
tests that rely on ICU or libxml being available.

_______________________________________________________

Reply to this item at:

<http://savannah.gnu.org/bugs/?53941>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/